Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add loading animations to the 'See Results' button #1887

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Add loading animations to the 'See Results' button #1887

merged 1 commit into from
Oct 6, 2022

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Oct 6, 2022

Fixes

Fixes #1808 by @obulat, building on top of past work by @obulat

Description

This PR adds animation to the 'See Results' button. There are two kinds of animations, based on the reduced animation preference.

Testing Instructions

  1. Check out the PR and run the Storybook.
  2. Check the 'Components/VHeader/VHeaderMobile/VShowResultsButton' story.
  3. In Chrome dev tools, you can emulate the 'prefers-reduced-motion' preference to see the other animation.

Screenshots

Screen.Recording.2022-10-06.at.7.27.26.PM.mov
Screen.Recording.2022-10-06.at.7.34.29.PM.mov

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 🕹 aspect: interface Concerns end-users' experience with the software labels Oct 6, 2022
@dhruvkb dhruvkb requested a review from a team as a code owner October 6, 2022 15:37
@dhruvkb dhruvkb requested review from zackkrida and obulat October 6, 2022 15:37
@github-actions
Copy link

github-actions bot commented Oct 6, 2022 •
edited
Loading

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/1887
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/1887/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Size Change: +869 B (0%)

Total Size: 816 kB

Filename Size Change
./.nuxt/dist/client/232.js 1.85 kB +1.58 kB (+581%) 🆘
./.nuxt/dist/client/232.modern.js 0 B -276 B (removed) 🏆
./.nuxt/dist/client/233.js 0 B -1.85 kB (removed) 🏆
./.nuxt/dist/client/app.js 132 kB +359 B (0%)
./.nuxt/dist/client/app.modern.js 124 kB +340 B (0%)
./.nuxt/dist/client/commons/app.js 88.2 kB +16 B (0%)
./.nuxt/dist/client/components/v-sources-table.js 15.3 kB +85 B (+1%)
./.nuxt/dist/client/components/v-sources-table.modern.js 15.3 kB +84 B (+1%)
./.nuxt/dist/client/vendors/app.modern.js 56.3 kB +14 B (0%)
./.nuxt/dist/client/231.js 272 B +272 B (new file) 🆕
./.nuxt/dist/client/231.modern.js 276 B +276 B (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./.nuxt/dist/client/commons/app.modern.js 77 kB -3 B (0%)
./.nuxt/dist/client/components/loading-icon.js 747 B +2 B (0%)
./.nuxt/dist/client/components/loading-icon.modern.js 750 B 0 B
./.nuxt/dist/client/components/table-sort-icon.js 509 B 0 B
./.nuxt/dist/client/components/table-sort-icon.modern.js 513 B -1 B (0%)
./.nuxt/dist/client/components/v-all-results-grid.js 2.75 kB -1 B (0%)
./.nuxt/dist/client/components/v-all-results-grid.modern.js 2.72 kB -3 B (0%)
./.nuxt/dist/client/components/v-all-results-grid/pages/search/audio/pages/search/index.js 3.02 kB -1 B (0%)
./.nuxt/dist/client/components/v-all-results-grid/pages/search/audio/pages/search/index.modern.js 2.91 kB +1 B (0%)
./.nuxt/dist/client/components/v-audio-cell.js 357 B 0 B
./.nuxt/dist/client/components/v-audio-cell.modern.js 360 B 0 B
./.nuxt/dist/client/components/v-audio-details.js 1.82 kB 0 B
./.nuxt/dist/client/components/v-audio-details.modern.js 1.79 kB +1 B (0%)
./.nuxt/dist/client/components/v-audio-track-skeleton.js 1.01 kB -1 B (0%)
./.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 1.02 kB +1 B (0%)
./.nuxt/dist/client/components/v-audio-track.js 5.12 kB +1 B (0%)
./.nuxt/dist/client/components/v-audio-track.modern.js 5.06 kB -1 B (0%)
./.nuxt/dist/client/components/v-back-to-search-results-link.js 569 B -1 B (0%)
./.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 573 B 0 B
./.nuxt/dist/client/components/v-bone.js 685 B 0 B
./.nuxt/dist/client/components/v-bone.modern.js 689 B -2 B (0%)
./.nuxt/dist/client/components/v-box-layout.js 1.2 kB 0 B
./.nuxt/dist/client/components/v-box-layout.modern.js 1.2 kB +1 B (0%)
./.nuxt/dist/client/components/v-content-link.js 1.11 kB -1 B (0%)
./.nuxt/dist/client/components/v-content-link.modern.js 1.09 kB +1 B (0%)
./.nuxt/dist/client/components/v-content-page.js 467 B +1 B (0%)
./.nuxt/dist/client/components/v-content-page.modern.js 471 B 0 B
./.nuxt/dist/client/components/v-content-report-button.js 777 B -1 B (0%)
./.nuxt/dist/client/components/v-content-report-button.modern.js 784 B +3 B (0%)
./.nuxt/dist/client/components/v-content-report-form.js 3.75 kB 0 B
./.nuxt/dist/client/components/v-content-report-form.modern.js 3.57 kB +2 B (0%)
./.nuxt/dist/client/components/v-content-report-popover.js 4.43 kB -3 B (0%)
./.nuxt/dist/client/components/v-content-report-popover.modern.js 4.24 kB +3 B (0%)
./.nuxt/dist/client/components/v-copy-button.js 3.97 kB -1 B (0%)
./.nuxt/dist/client/components/v-copy-button.modern.js 3.98 kB -2 B (0%)
./.nuxt/dist/client/components/v-copy-license.js 998 B 0 B
./.nuxt/dist/client/components/v-copy-license.modern.js 998 B -3 B (0%)
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.js 9.47 kB 0 B
./.nuxt/dist/client/components/v-copy-license/components/v-error-image/components/v-media-reuse/components/v-search-grid/09090664.modern.js 9.44 kB -2 B (0%)
./.nuxt/dist/client/components/v-dmca-notice.js 748 B -1 B (0%)
./.nuxt/dist/client/components/v-dmca-notice.modern.js 752 B -1 B (0%)
./.nuxt/dist/client/components/v-error-image.js 1.69 kB -1 B (0%)
./.nuxt/dist/client/components/v-error-image.modern.js 1.68 kB 0 B
./.nuxt/dist/client/components/v-error-section.js 372 B 0 B
./.nuxt/dist/client/components/v-error-section.modern.js 376 B 0 B
./.nuxt/dist/client/components/v-external-search-form.js 3.11 kB +1 B (0%)
./.nuxt/dist/client/components/v-external-search-form.modern.js 3.09 kB +2 B (0%)
./.nuxt/dist/client/components/v-external-source-list.js 2.57 kB +2 B (0%)
./.nuxt/dist/client/components/v-external-source-list.modern.js 2.54 kB +2 B (0%)
./.nuxt/dist/client/components/v-full-layout.js 1.49 kB +1 B (0%)
./.nuxt/dist/client/components/v-full-layout.modern.js 1.48 kB 0 B
./.nuxt/dist/client/components/v-grid-skeleton.js 1.6 kB -2 B (0%)
./.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.61 kB +2 B (0%)
./.nuxt/dist/client/components/v-image-cell-square.js 1.02 kB +1 B (0%)
./.nuxt/dist/client/components/v-image-cell-square.modern.js 1.02 kB -1 B (0%)
./.nuxt/dist/client/components/v-image-cell.js 1.43 kB 0 B
./.nuxt/dist/client/components/v-image-cell.modern.js 1.42 kB -1 B (0%)
./.nuxt/dist/client/components/v-image-details.js 1.44 kB -1 B (0%)
./.nuxt/dist/client/components/v-image-details.modern.js 1.44 kB +1 B (0%)
./.nuxt/dist/client/components/v-image-grid.js 2.54 kB +2 B (0%)
./.nuxt/dist/client/components/v-image-grid.modern.js 2.42 kB -3 B (0%)
./.nuxt/dist/client/components/v-license-tab-panel.js 522 B +1 B (0%)
./.nuxt/dist/client/components/v-license-tab-panel.modern.js 525 B 0 B
./.nuxt/dist/client/components/v-load-more.js 788 B 0 B
./.nuxt/dist/client/components/v-load-more.modern.js 683 B 0 B
./.nuxt/dist/client/components/v-media-license.js 799 B 0 B
./.nuxt/dist/client/components/v-media-license.modern.js 808 B +1 B (0%)
./.nuxt/dist/client/components/v-media-reuse.js 1.62 kB -1 B (0%)
./.nuxt/dist/client/components/v-media-reuse.modern.js 1.61 kB -3 B (0%)
./.nuxt/dist/client/components/v-media-tag.js 430 B 0 B
./.nuxt/dist/client/components/v-media-tag.modern.js 434 B 0 B
./.nuxt/dist/client/components/v-no-results.js 2.77 kB +2 B (0%)
./.nuxt/dist/client/components/v-no-results.modern.js 2.74 kB -1 B (0%)
./.nuxt/dist/client/components/v-radio.js 1.51 kB 0 B
./.nuxt/dist/client/components/v-radio.modern.js 1.47 kB +2 B (0%)
./.nuxt/dist/client/components/v-related-audio.js 1.23 kB +5 B (0%)
./.nuxt/dist/client/components/v-related-audio.modern.js 1.23 kB 0 B
./.nuxt/dist/client/components/v-related-images.js 3.09 kB 0 B
./.nuxt/dist/client/components/v-related-images.modern.js 2.97 kB -2 B (0%)
./.nuxt/dist/client/components/v-report-desc-form.js 966 B +1 B (0%)
./.nuxt/dist/client/components/v-report-desc-form.modern.js 966 B +2 B (0%)
./.nuxt/dist/client/components/v-row-layout.js 1.7 kB 0 B
./.nuxt/dist/client/components/v-row-layout.modern.js 1.7 kB 0 B
./.nuxt/dist/client/components/v-scroll-button.js 814 B +1 B (0%)
./.nuxt/dist/client/components/v-scroll-button.modern.js 819 B 0 B
./.nuxt/dist/client/components/v-search-grid.js 5.46 kB +5 B (0%)
./.nuxt/dist/client/components/v-search-grid.modern.js 5.4 kB 0 B
./.nuxt/dist/client/components/v-search-results-title.js 658 B -2 B (0%)
./.nuxt/dist/client/components/v-search-results-title.modern.js 652 B +1 B (0%)
./.nuxt/dist/client/components/v-search-type-radio.js 793 B -1 B (0%)
./.nuxt/dist/client/components/v-search-type-radio.modern.js 768 B 0 B
./.nuxt/dist/client/components/v-server-timeout.js 299 B 0 B
./.nuxt/dist/client/components/v-server-timeout.modern.js 303 B 0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.js 995 B 0 B
./.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 895 B +1 B (0%)
./.nuxt/dist/client/components/v-skip-to-content-container.js 888 B -1 B (0%)
./.nuxt/dist/client/components/v-skip-to-content-container.modern.js 894 B 0 B
./.nuxt/dist/client/components/v-snackbar.js 1.18 kB 0 B
./.nuxt/dist/client/components/v-snackbar.modern.js 1.19 kB -1 B (0%)
./.nuxt/dist/client/components/v-warning-suppressor.js 298 B 0 B
./.nuxt/dist/client/components/v-warning-suppressor.modern.js 303 B 0 B
./.nuxt/dist/client/pages/about.js 1.06 kB -1 B (0%)
./.nuxt/dist/client/pages/about.modern.js 1.07 kB 0 B
./.nuxt/dist/client/pages/audio/_id.js 4.93 kB -2 B (0%)
./.nuxt/dist/client/pages/audio/_id.modern.js 4.76 kB -2 B (0%)
./.nuxt/dist/client/pages/external-sources.js 1.45 kB 0 B
./.nuxt/dist/client/pages/external-sources.modern.js 1.45 kB +3 B (0%)
./.nuxt/dist/client/pages/feedback.js 1.24 kB 0 B
./.nuxt/dist/client/pages/feedback.modern.js 1.24 kB -1 B (0%)
./.nuxt/dist/client/pages/image/_id.js 5.3 kB +3 B (0%)
./.nuxt/dist/client/pages/image/_id.modern.js 7.24 kB -9 B (0%)
./.nuxt/dist/client/pages/index.js 5.05 kB +1 B (0%)
./.nuxt/dist/client/pages/index.modern.js 4.91 kB -2 B (0%)
./.nuxt/dist/client/pages/preferences.js 1.21 kB -2 B (0%)
./.nuxt/dist/client/pages/preferences.modern.js 1.21 kB +1 B (0%)
./.nuxt/dist/client/pages/search-help.js 1.54 kB 0 B
./.nuxt/dist/client/pages/search-help.modern.js 1.55 kB +1 B (0%)
./.nuxt/dist/client/pages/search.js 2.75 kB -2 B (0%)
./.nuxt/dist/client/pages/search.modern.js 2.6 kB +2 B (0%)
./.nuxt/dist/client/pages/search/audio.js 1.19 kB -2 B (0%)
./.nuxt/dist/client/pages/search/audio.modern.js 1.19 kB -2 B (0%)
./.nuxt/dist/client/pages/search/image.js 2.79 kB +3 B (0%)
./.nuxt/dist/client/pages/search/image.modern.js 2.67 kB -3 B (0%)
./.nuxt/dist/client/pages/search/index.js 2.96 kB -2 B (0%)
./.nuxt/dist/client/pages/search/index.modern.js 2.94 kB -5 B (0%)
./.nuxt/dist/client/pages/search/model-3d.js 242 B -1 B (0%)
./.nuxt/dist/client/pages/search/model-3d.modern.js 246 B 0 B
./.nuxt/dist/client/pages/search/search-page.types.js 266 B +1 B (0%)
./.nuxt/dist/client/pages/search/search-page.types.modern.js 269 B -2 B (-1%)
./.nuxt/dist/client/pages/search/video.js 239 B 0 B
./.nuxt/dist/client/pages/search/video.modern.js 244 B +1 B (0%)
./.nuxt/dist/client/pages/sources.js 1.45 kB +4 B (0%)
./.nuxt/dist/client/pages/sources.modern.js 1.45 kB 0 B
./.nuxt/dist/client/runtime.js 2.7 kB -6 B (0%)
./.nuxt/dist/client/runtime.modern.js 2.7 kB -7 B (0%)
./.nuxt/dist/client/vendors/app.js 57.2 kB -1 B (0%)

compressed-size-action

obulat
obulat approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really love the animation and your solution for the (no) change in button width!

zackkrida
zackkrida approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! In the future, I wonder if we should throttle the filter selection so that:

  1. At least one animation cycle of the button can complete
  2. If the user is clicking multiple filters rapidly in X seconds, only a single request will be made

@dhruvkb dhruvkb merged commit 16a1f24 into main Oct 6, 2022
@dhruvkb dhruvkb deleted the see_res_anim branch October 6, 2022 22:24
github-actions bot pushed a commit that referenced this pull request Oct 6, 2022
@openverse-bot
Clean preview for PR #1887
52f9996
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obulat obulat obulat approved these changes

@zackkrida zackkrida zackkrida approved these changes

Assignees
No one assigned
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component: VShowResults button
3 participants
@dhruvkb @zackkrida @obulat