Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Component: VShowResults button #1808

Closed
1 task
obulat opened this issue Sep 14, 2022 · 1 comment · Fixed by #1887
Closed
1 task

Component: VShowResults button #1808

obulat opened this issue Sep 14, 2022 · 1 comment · Fixed by #1887
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon

Comments

@obulat
Copy link
Contributor

obulat commented Sep 14, 2022

All work for the 'Create new header' milestone should be done under the new_header feature flag.

Description

The mobile content settings modal shows a "Show results" button which, when clicked, closes the modal. The button also shows an animation when the results are being fetched.

API

Props

Name Type Description
isFetching boolean Whether the media is being fetched. If true, the dots animation is shown instead of the label

Events

Name Associated data Description
click - click event is sent to the parent to close the modal.

Code samples

<VButton>
  <span v-if="isFetching">
    ...loading animation svg
  </span>
  <span v-else>
    {{ $t('show-results') }}
  </span>
</VButton>

Dependencies

References

The animation can probably be based on the animation of the VLogoButton.

Implementation

  • 🙋 I would be interested in implementing this component.
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🌟 goal: addition Addition of new feature 🕹 aspect: interface Concerns end-users' experience with the software labels Sep 14, 2022
@obulat obulat added this to the Create new header milestone Sep 14, 2022
@obulat
Copy link
Contributor Author

obulat commented Oct 4, 2022

Note that the stub of the button without animation is implemented in #1846

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants