This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add a tabbed ContentSettings mobile modal #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1846 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
✨ goal: improvement
|
Size Change: -19.8 kB (-2%) Total Size: 813 kB
ℹ️ View Unchanged
|
|
I'm not sure the <VMobileModal>
<VTabs>
<template #tabs>
<VTab v-for="tab in tabs" :id="tab" :key="tab">
{{ 'tab name here' }}
</VTab>
<VIconButton
class="ms-auto"
@click="$emit('close')"
/>
</template>
<ContentTypeTabPanel />
<FiltersTabPanel />
</VTabs>
</VMobileModal> |
Thank you, @zackkrida, this is a much better suggestion! |
obulat
force-pushed
the
add/closable_tabs
branch
2 times, most recently
from
5b0460b to
13aae6d
Compare
zackkrida
requested review from
dhruvkb
and removed request for
sarayourfriend
obulat
force-pushed
the
add/closable_tabs
branch
from
481b0a8 to
a5c8f35
Compare
obulat
force-pushed
the
add/closable_tabs
branch
from
e393c0a to
6e147eb
Compare
obulat
force-pushed
the
add/closable_tabs
branch
2 times, most recently
from
5f95c66 to
c8c2147
Compare
zackkrida
suggested changes
Oct 4, 2022
For the filters sidebar, we've added the special handling of the Tab buttons on the last element: it should focus the first tabbable element in |
Use ::after for tab underline and add medium size VTab Create VContentSettingsTabs component Fix Storybook build Move components to VHeaderMobile directory Fix tablist styles Remove unused style declaration Polish the modal Add text button snapshots Make the modal footer buttons available in the page Tabbing order Correct text button hover style Update snapshots
obulat
force-pushed
the
add/closable_tabs
branch
from
7653261 to
8a5f3ba
Compare
dhruvkb
approved these changes
Oct 6, 2022
obulat
added
🌟 goal: addition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1847 by @obulat
Description
This PR adds a
VContentSettingsModalcomponent that is a modal 2/3 the height of the window. It is only displayed on mobile widths, and shows two tabs: Content switcher and the Filters.Testing Instructions
Run the app and go to 'https://localhost:8443/search/?q=cat&ff_new_header=on' on mobile width. When you click on the ContentSettings button in the header, the modal should open. You should be able to change the content settings (search type, filters) using the modal, and close it by clicking on the 'Close' button.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin