Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add focus style for play/pause button #170

Merged
merged 1 commit into from
Aug 30, 2021
Merged

Add focus style for play/pause button #170

merged 1 commit into from
Aug 30, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Aug 30, 2021

Fixes

Fixes #148 by @sarayourfriend

Description

This PR adds a ring around the play/pause toggle button when focused. The Tailwind config added in the PR would also be useful in resolving #147.

Technical details

The focus outline is only shown for the focus-visible state. Browser support is good but Safari is the next IE.

Screenshots

Screenshot 2021-08-30 at 9 32 54 AM

The border fades in and out, similar to Gutenberg. Since the button has no rounded corners, neither does the outline.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner August 30, 2021 04:04
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhruvkb dhruvkb merged commit 4fb8957 into audio Aug 30, 2021
@zackkrida zackkrida added the ✨ goal: improvement Improvement to an existing user-facing feature label Sep 8, 2021
@dhruvkb dhruvkb deleted the focus_styles branch September 8, 2021 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ goal: improvement Improvement to an existing user-facing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants