-
Notifications
You must be signed in to change notification settings - Fork 63
[Feature] Waveform focus styles #147
Comments
@panchovm This needs some small design thinking applied, please! |
Yes. I'm working this week on this |
I am trying different styles, but something that comes to my mind is how the interaction works. Once the focus is on the waveform and arrow keys go forward/backward, does it play the sound immediately? Or does it need a second action (like space bar) to start playing? On youtube, it is tied to the previous state. If the video is playing, arrow keys go 5 secs forward/backward and the video plays immediately. If the video is paused, it does not play until pressing the space bar. Same on SoundCloud and Spotify. Last.fm allows playing/pause with the space bar but not moving across time with arrow keys. While Europeana, Jamendo, and Wikimedia Commons do not allow navigation on the audio time. YoutubeSoundcloudSpotify web |
It works the same as YouTube and Spotify 🙂 Which I think is the most sensible. If you're trying to seek to a specific time before playing the audio, it would be really surprising to me if it suddenly started playing as well. In any case, if seeking using the keyboard we'd have to debounce the auto-playing behavior for some arbitrary amount of time. |
Right. That makes sense. Now I wonder how useful is the 1-sec navigation feature, especially on long audios. I agree with the idea of missing specific seconds, but I guess that seeking time 01:13 but arriving and playing from 01:10 is not annoying. Youtube iOS has jump periods of 10, 20, 30, and 40 seconds when tapping the video area to go forward and backward. I wonder how that behavior might feel in this case. |
@panchovm we have a modifier for |
You are right. We decided that and I forgot it. Thanks for bringing it back. |
Here is the version I like most. Once the focus is on the wave area, the focus mark is visible and, depending on the audio state (play or pause), it behaves as indicated above. I would like to see how it feels when interacting in real since the mockup is a static depiction. I tried other styles but did not like them much, yet attached below. Audio component partsWhile designing the component, I faced many unnamed parts that might be a good idea to call them somehow. That is why I made this draft to align us with all concepts used from now. Indeed, this is fully open to changes and enhancements. |
Here is the last version of audio component with all states. |
@panchovm that's great! I was going to comment (but forgot to) on the PR that it was hard to notice that the area was focused at all without an additional outline. |
Problem
The waveform does not have a clear focus style, meaning that sighted keyboard users will have a difficult time knowing that they are able to seek using the keyboard like other "seek bars" that exist.
Description
We should add a focus style that makes it clear to sighted keyboard users that they can seek using the arrow keys. Screen reader users will get an indiciation from their screen reader that they are in a "slider" which will give the hint that they can use the arrow keys to interact, but for non-screen reader keyboard users this will not apply. Therefore we need some kind of visual indication that the waveform is focused and seekable.
One potential solution is to make the vertical "seek" line a solid color with a circle or bulb at the top. Similar to how iOS represents a video scub in the Photos app, but with a bulb at the top of the line to add an extra indication (especially when the audio is at the
0:00
timestamp something will need to be visible inside of the waveform).Alternatives
I'm sure there are other designs we could do for the focus styles, but I'm not sure of any.
Implementation
The text was updated successfully, but these errors were encountered: