This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add TS to useWindowScroll #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
🟩 priority: low
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/_preview/1590 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
|
Size Change: -76.3 kB (-5%) ✅ Total Size: 1.33 MB
ℹ️ View Unchanged
|
obulat
reviewed
Jul 29, 2022
| ...props, | ||
| } as unknown as typeof window) | ||
|
|
||
| const UseWindowScrollTestContainer = Vue.component( |
There was a problem hiding this comment.
I think it might be possible to create a "generic" component for this to test composables, but I'm not sure 😅
dhruvkb
approved these changes
Aug 4, 2022
| @@ -52,5 +58,5 @@ export function useWindowScroll({ | |||
| passive: true, | |||
| }) | |||
|
|
|||
| return { x, y, isScrolled } | |||
| return Object.freeze({ x, y, isScrolled }) | |||
There was a problem hiding this comment.
I don't understand why this object is frozen.
There was a problem hiding this comment.
To encode the immutability of the structure? Changing the structure of this object is meaningless so why allow it? Maybe I am over thinking this though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Part of a broader TS-ification project and necessary for TS-ifying the last blocking component: VPopover.
Description
Updates
useWindowScrollto use TypeScript and adds unit tests. Also removes the usage of deprecated window properties.Testing Instructions
Ensure CI and e2e tests work as expected.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin