Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add types to composables/use-window-scroll.js #964

Closed
1 task
sarayourfriend opened this issue Feb 21, 2022 · 1 comment
Closed
1 task

Add types to composables/use-window-scroll.js #964

sarayourfriend opened this issue Feb 21, 2022 · 1 comment
Assignees
@sarayourfriend
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed
Milestone
TypeScriptification

Comments

@sarayourfriend
Copy link
Contributor

sarayourfriend commented Feb 21, 2022 •
edited by zackkrida
Loading

Description

Add type checking to use-window-scroll.js. This module has one untyped dependency that will be typed in #952. Make sure to add it to tsconfig.json's include list.

Blocked by #952

Additional context

Part of an ongoing effort to add type checking to parts of the project that can be type checked.

Implementation

  • 🙋 I would be interested in implementing this feature.
@sarayourfriend sarayourfriend added good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Feb 21, 2022
@sarayourfriend sarayourfriend added this to the TypeScriptification milestone Feb 21, 2022
@obulat obulat added 🧰 goal: internal improvement Improvement that benefits maintainers, not users and removed ✨ goal: improvement Improvement to an existing user-facing feature labels May 13, 2022
@obulat
Copy link
Contributor

obulat commented Aug 12, 2022

This issue was solved in #1590.

@obulat obulat closed this as completed Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sarayourfriend sarayourfriend

Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Milestone
TypeScriptification
Development

No branches or pull requests
2 participants
@obulat @sarayourfriend