This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Fix stories for VContentLink and VSearchTypePopover
#1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1383 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
💻 aspect: code
|
Size Change: +4 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
|
Why is the Nuxt app build size changing when stories are modified 🤔? |
|
Not sure why, but it is concerning that a noop (from nuxt's perspective) is causing an increase. |
sarayourfriend
approved these changes
May 4, 2022
|
@dhruvkb I noticed the VPopover / Control story is broken, not sure if it's a problem with the component, do you want to include it here? We can create another ticket for that any time of course. |
|
I'll fix it here itself, avoid the overhead of filling a ticket and making the PR. |
|
@krysal I can't reproduce, the story renders normally for me. Can you add the repro steps? |
|
You can see it here: https://wordpress.github.io/openverse-frontend/1383/?path=/story/components-vpopover--control If you open the popover and then click outside of the popover to closes it will crash on I suspect this is probably an error in the dialog composables, not with the story though. Is that what you were talking about @krysal ? |
|
That's correct @sarayourfriend, I forgot to mention it's the interaction with the popover that is broken. |
|
If it's not a story issue, I'll merge this PR. |
dhruvkb
changed the title
VContentLink and VSearchTypePopover
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1135 by @dhruvkb
Description
This PR fixes two stories
VContentLinkwhich is broken in the UIVSearchTypePopoverwhich has the wrong file nameTesting Instructions
VContentLinkworks (which it doesn't onmain).VSearchTypePopoverstory matches the component name.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin