Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Lots of stories broken in Canvas view #1135

Closed
1 task
dhruvkb opened this issue Mar 17, 2022 · 2 comments · Fixed by #1383
Closed
1 task

Lots of stories broken in Canvas view #1135

dhruvkb opened this issue Mar 17, 2022 · 2 comments · Fixed by #1383
Assignees
@dhruvkb
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Mar 17, 2022

Description

Many stories in the Storybook on main are broken. This might be a consequence of updating it to Storybook 6.4 although there are no breaking changes in the changelog. Strangely enough, the smoke test passes.

Reproduction

Visit the "Components/VAudioThumbnail/Square" story in the "Canvas" view. There might be other stories broken in a similar fashion.

Expectation

The stories should render.

Additional context

The broken stories can be fixed by using the composition API format with a setup() function. See #1134 which fixes the stories for "Components/VLicense".

Resolution

  • 🙋 I would be interested in resolving this bug.
@dhruvkb dhruvkb added good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Mar 17, 2022
@dhruvkb dhruvkb mentioned this issue Apr 1, 2022
Merged
7 tasks
@obulat obulat mentioned this issue Apr 3, 2022
Merged
7 tasks
@sarayourfriend
Copy link
Contributor

@dhruvkb this is fixed now right?

@dhruvkb
Copy link
Member Author

dhruvkb commented Apr 15, 2022 •
edited
Loading

I'm not sure, we fixed a lot but not comprehensively all of them. I'll quickly check and update the ticket.

@dhruvkb dhruvkb self-assigned this Apr 15, 2022
@dhruvkb dhruvkb mentioned this issue May 4, 2022
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dhruvkb dhruvkb

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix stories for VContentLink and VSearchTypePopover WordPress/openverse-frontend
2 participants
@dhruvkb @sarayourfriend