Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix VErrorSection stories #1224

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Fix VErrorSection stories #1224

merged 1 commit into from
Apr 3, 2022

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Apr 3, 2022

Fixes

Related to #1135 by @dhruvkb

Description

Small fix for the VErrorSection stories that converts them to the Composition API format. This PR is based on @dhruvkb 's fix_stories branch. Feel free to change/merge it as you see fit, @dhruvkb .

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Apr 3, 2022
@obulat obulat requested a review from a team as a code owner April 3, 2022 05:05
@obulat obulat requested review from krysal and sarayourfriend April 3, 2022 05:05
@dhruvkb
Copy link
Member

dhruvkb commented Apr 3, 2022

This is great, thanks! I'm afk rn but will merge as soon as I'm back.

@dhruvkb dhruvkb merged commit f81bc55 into fix_stories Apr 3, 2022
@dhruvkb dhruvkb deleted the fix_stories_error_section branch April 3, 2022 05:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants