This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Define and document the MediaTag
component
#136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvkb
requested review from
zackkrida and
krysal
and removed request for
a team
August 19, 2021 07:25
zackkrida
suggested changes
Aug 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, just a few things:
- We should only have a hover state if the element is a link/button/etc. these can also potentially be used just to display a non-interactive tag.
- All hover styles should also apply on focus
- The hover state is not documented and I discussed a bit with @panchovm, the final hover state would more likely be dark grey background with light text.
We don't plan to use this component as a link to filter/navigate the search results, so we should not have the link states. This might change, but I suggest keeping it as simple as possible. I'm tasked with the single result mockup where this element will be. |
zackkrida
approved these changes
Aug 20, 2021
krysal
approved these changes
Aug 23, 2021
zackkrida
added
the
✨ goal: improvement
Improvement to an existing user-facing feature
label
Sep 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please merge #127 before this
Description
This PR adds the
MediaTag
component that represents one tag associated with a media item.Screenshots
Checklist
Update index.md
).main
ormaster
).Developer Certificate of Origin
Developer Certificate of Origin