-
Notifications
You must be signed in to change notification settings - Fork 63
Create the audio track component #127
Conversation
So happy to see the resampling work, amazing |
Added a quick event handler to make the progress user-settable. you don't have to go with this implementation of course :)
|
I just finished that same stuff locally @zackkrida. Now I'm
|
@zackkrida I made some tweaks and merged your PR, thanks for chipping in! I've also done most of the seekbar implementation in the actual |
What's important is that we had fun! Haha, it is the weekend after all. Excited to look at the approach you went with. |
By the way @dhruvkb, this is looking amazing, and don't worry, I won't interrupt your work with contributions of my own 😆. I'm realizing we need @panchovm to design a state for when you go seek backwards over the yellow bar. maybe the bars could be white or something? not sure. If you need me to describe the state we need better @panchovm I can elaborate next week. |
Hahaha, I'm heading off to sleep now, feel free to add any changes you find! |
I tweaked the appearance a little bit to change how the seek process looks when seeking behind progress in d6113cb. |
All this looks awesome. Thank you both. Regarding going backward, I was thinking of keeping the same black bars interactions. The yellow background fills the area slowly as the seconds pass, while the black bars show what time the user wants to start playing, no matter if the yellow area is ahead or behind. The wave area (gray bars) works independently of the playing area (yellow background) when the user hovers the whole audio section. I hope I explained myself correctly. |
@panchovm I think I got what you mean. That's great because d6113cb implements exactly the same idea that you mentioned 🎉! |
@panchovm for reference, here is the current implementation: CleanShot.2021-08-17.at.09.46.50.mp4 |
@dhruvkb I cleaned up the git history here, you might want to |
In <Waveform
+ v-if="audio.peaks"
class="h-30 w-full"
:is-ready="isReady"
:current-time="currentTime"
:duration="duration"
:peaks="audio.peaks"
@seeked="setPosition"
/> Otherwise this is looking really good. Do we want to include all a11y work here or in a subsequent pr? |
Improving a11y in a subsequent PR would be better, as getting the Storybook merged allows other components to be developed on the side. |
@zackkrida your suggestion about removing the waveform in the absence of peaks will need a design update because the waveform is both the progress and the seek bar. Without it, we need an alternative way to serve these functions. CC: @panchovm |
I'm also fine with some kind of way to guarantee we have the waveform elsewhere in the stack. If we can assume we have the audio, we can assume we have the waveform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's so exciting to see the track component playing the audio! It looks simple but at the same time, it has so many carefully thought out and cared details. Excellent work, thanks!
Fixes
Fixes #104 by @zackkrida
Description
This PR creates the audio track component and any other components needed by it.
Checklist
Update index.md
).main
ormaster
).Developer Certificate of Origin
Developer Certificate of Origin