Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove lodash.set #1336

Merged
merged 2 commits into from
Apr 28, 2022
Merged

Remove lodash.set #1336

merged 2 commits into from
Apr 28, 2022

Conversation

sarayourfriend
Copy link
Contributor

Fixes

Fixes #1107 by @sarayourfriend

Description

Replaces lodash.set with a smaller implementation from SO. This should prevent accidentally using it in the actual app.

Testing Instructions

Checkout this branch and delete your local translation .json files other than en.json. Copy one of them first to compare to the output. Then run pnpm i18n. The output of the file you copied should match the newly generated one.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend requested a review from a team as a code owner April 27, 2022 07:26
@openverse-bot openverse-bot added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟩 priority: low Low priority and doesn't need to be rushed labels Apr 27, 2022
@sarayourfriend sarayourfriend force-pushed the update/remove-lodash.set branch from 16768eb to 5e3ddf1 Compare April 28, 2022 05:46
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see another lodash package gone!

src/locales/scripts/utils.js Outdated Show resolved Hide resolved
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
@sarayourfriend sarayourfriend enabled auto-merge (squash) April 28, 2022 13:29
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarayourfriend sarayourfriend merged commit bd84bdb into main Apr 28, 2022
@sarayourfriend sarayourfriend deleted the update/remove-lodash.set branch April 28, 2022 13:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace lodash.set with small and simple custom implementation
4 participants