Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Replace lodash.set with small and simple custom implementation #1107

Closed
1 task
sarayourfriend opened this issue Mar 11, 2022 · 0 comments · Fixed by #1336
Closed
1 task

Replace lodash.set with small and simple custom implementation #1107

sarayourfriend opened this issue Mar 11, 2022 · 0 comments · Fixed by #1336
Assignees
@sarayourfriend
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed
Milestone
Remove lodash

Comments

@sarayourfriend
Copy link
Contributor

sarayourfriend commented Mar 11, 2022 •
edited
Loading

Problem

We are looking to remove dependency on lodash altogether (see milestone description).

Description

Replace all usages of lodash.set with this small custom implementation: https://stackoverflow.com/a/6842900

Additional context

This is currently only used in development translation scripts. The implementation linked is a tiny fraction of the size of the lodash implementation.

Implementation

  • 🙋 I would be interested in implementing this feature.
@sarayourfriend sarayourfriend added good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Mar 11, 2022
@sarayourfriend sarayourfriend added this to the Remove lodash milestone Mar 11, 2022
@sarayourfriend sarayourfriend mentioned this issue Apr 27, 2022
Merged
6 tasks
@sarayourfriend sarayourfriend self-assigned this Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sarayourfriend sarayourfriend

Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Milestone
Remove lodash
Development

Successfully merging a pull request may close this issue.

Remove lodash.set WordPress/openverse-frontend
1 participant
@sarayourfriend