-
Notifications
You must be signed in to change notification settings - Fork 63
Refine configurations for the vue-i18n eslint plugin #1252
Conversation
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
// Brand names that should not be translated | ||
'Common Crawl', | ||
'Creative Commons', | ||
'Europeana', | ||
'Flickr', | ||
'Openverse', | ||
'WordPress', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This is a great find.
@krysal I just found out about the How do you feel about adding that to this PR (or to the base branch for this PR)? That way we can close #1160. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love how cleaner the right side of the diff looks, @krysal ! Thank you for fixing this.
Great find @sarayourfriend! Added in 133c471. |
Fixes
Related to #1160 by @sarayourfriend
Description
This PR:
It builds on top of #1239 that fixes the
lint
andlint:fix
commands.Testing Instructions
Look at the Files changed tab of this PR and observe there are no warnings annotations. Try adding raw text different to brand names in templates, then run
pnpm lint
and observe the error is announced.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin