Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix command for code formatting #1239

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Fix command for code formatting #1239

merged 3 commits into from
Apr 11, 2022

Conversation

krysal
Copy link
Member

@krysal krysal commented Apr 5, 2022

Follow up of #1207 by @dhruvkb

Description

The pnpm lint:fix command was not applying format corrections, it was just showing the errors and warnings as in pnpm lint. Here I added new commands to keep the style of the cleanup 🙂 Let me know if it isn't too much, maybe we can omit lint:prettier.

Testing Instructions

  1. In main make any code style modifications, it could be something simple like adding several new lines in a component template, then run pnpm lint:fix and observe the code doesn´t change.
  2. Check out this branch and repeat, the code should be formatted now.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase labels Apr 5, 2022
@krysal krysal requested a review from a team as a code owner April 5, 2022 17:06
@krysal krysal self-assigned this Apr 5, 2022
@krysal krysal requested review from obulat and dhruvkb April 5, 2022 17:06
package.json Show resolved Hide resolved
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it! I got a bit confused by unknown flag --fix received error when running lint:fix previously.

package.json Outdated Show resolved Hide resolved
Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Running prettier twice in the fix script is annoying but not that bad overall! I can live with 🙂

@krysal krysal merged commit d809785 into main Apr 11, 2022
@krysal krysal deleted the fix_lint_fix_command branch April 11, 2022 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants