-
Notifications
You must be signed in to change notification settings - Fork 63
Remove scss lang directives from Vue SFC style tags; add eslint rule #1200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
'vue/block-lang': [ | ||
'error', | ||
{ | ||
style: { allowNoLang: true }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds like it's allowed not to indicate the lang
attribute instead of prohibiting it, a bit confusing to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krysal I added a comment to make this clearer, hopefully.
src/locales/po-files/openverse.pot
Outdated
@@ -1868,7 +1868,6 @@ msgctxt "hero.aria.search-type" | |||
msgid "search type" | |||
msgstr "" | |||
|
|||
#: src/components/LocaleSelector.vue:3 | |||
msgctxt "hero.locale.label" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The locale selector strings are still there in the .pot
file. I guess if we delete them from the JSON file, they will be removed from .pot
, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a couple of change requests in form of a PR: #1201. Other than that, everything LGTM! I thought this would require many more changes, especially around tabs.
* Move copy button styles to tailwind, add V prefix * Remove unused locale strings
Fixes
Fixes #1087 by @zackkrida
Description
Converts all Vue SFCs to plain css in the
<style>
tags. Also adds an eslint rule to prevent contributors from using scss or any lang in Vue SFCs.Testing Instructions
pnpm i
and try to add alang
to a style block in a Vue SFCChecklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin