Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove scss lang directives from Vue SFC style tags; add eslint rule #1200

Merged
merged 8 commits into from
Mar 29, 2022

Conversation

zackkrida
Copy link
Member

Fixes

Fixes #1087 by @zackkrida

Description

Converts all Vue SFCs to plain css in the <style> tags. Also adds an eslint rule to prevent contributors from using scss or any lang in Vue SFCs.

Testing Instructions

  • pnpm i and try to add a lang to a style block in a Vue SFC
  • Observe that modified pages look correct/consistent with their original appearances.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested a review from a team as a code owner March 28, 2022 21:07
@dhruvkb dhruvkb added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟩 priority: low Low priority and doesn't need to be rushed labels Mar 28, 2022
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

'vue/block-lang': [
'error',
{
style: { allowNoLang: true },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like it's allowed not to indicate the lang attribute instead of prohibiting it, a bit confusing to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krysal I added a comment to make this clearer, hopefully.

.eslintrc.js Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
@@ -1868,7 +1868,6 @@ msgctxt "hero.aria.search-type"
msgid "search type"
msgstr ""

#: src/components/LocaleSelector.vue:3
msgctxt "hero.locale.label"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The locale selector strings are still there in the .pot file. I guess if we delete them from the JSON file, they will be removed from .pot, too?

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a couple of change requests in form of a PR: #1201. Other than that, everything LGTM! I thought this would require many more changes, especially around tabs.

* Move copy button styles to tailwind, add V prefix

* Remove unused locale strings
@zackkrida zackkrida merged commit 7eac75b into main Mar 29, 2022
@zackkrida zackkrida deleted the remove-scss branch March 29, 2022 10:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert components using lang="scss" style blocks to plain css
4 participants