Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Convert components using lang="scss" style blocks to plain css #1087

Closed
zackkrida opened this issue Mar 9, 2022 · 0 comments · Fixed by #1200
Closed

Convert components using lang="scss" style blocks to plain css #1087

zackkrida opened this issue Mar 9, 2022 · 0 comments · Fixed by #1200
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed

Comments

@zackkrida
Copy link
Member

Many of our components use Sass in their style blocks instead of plain CSS. These should be converted to Tailwind where possible and scss should be eliminated. Many components with <style lang="scss"> aren't even using Sass features.

This reduces reliance on yet another technology in our toolchain, encourages better practices (if you feel like you need a loop/control structure in your css, you should probably write a Vue component instead of whatever logic you're writing), and, down the line, as part of the Remove legacy styles milestone, would let us remove around 6mb of dev dependencies, sass and sass-loader.

@zackkrida zackkrida added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Mar 9, 2022
@zackkrida zackkrida changed the title Convert components using lang="scss" style blocks to plain css Convert components using lang="scss" style blocks to plain css Mar 9, 2022
@sarayourfriend sarayourfriend removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants