This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to
openverse-api
issue#575.Description
The front end expects all audio peaks values to be non-negative integers in the range of [0..1]. However, some of the peaks values that API sends are negative.
This PR adjust the validator for peak values, and makes all the values at least zero.
To minimize the effect of this fix on performance, I added the
Math.max(0, value)
to the already existingmap
function that handles the peaks object.Testing Instructions
On the main branch, go to
http://localhost:8443/audio/727b9979-98f1-4604-9097-0a8b6fa68f2e/
. You should see a warning in the console saying "Invalid prop: custom validator check failed for prop "peaks".When opening the same page on this branch, you should not see this warning.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin