Hotfix for negative values in peaks (#1148)

* Hotfix for negative values in peaks * Validate peaks values only by checking if they are numbers
WordPress · Mar 21, 2022 · a469a57 · a469a57
1 parent 234b18b
commit a469a57
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/components/VAudioTrack/VWaveform.vue b/src/components/VAudioTrack/VWaveform.vue
@@ -187,7 +187,7 @@ export default defineComponent({
     peaks: {
       type: Array,
       required: false,
-      validator: (val) => val.every((item) => item >= 0 && item <= 1),
+      validator: (val) => val.every((item) => typeof item === 'number'),
     },
     /**
      * the message to display instead of the waveform; This is useful when
@@ -348,7 +348,9 @@ export default defineComponent({
         samples = downsampleArray(samples, required)
       }
 
-      return samples.map((peak) => peak * waveformDimens.value.height)
+      return samples.map(
+        (peak) => Math.max(peak, 0) * waveformDimens.value.height
+      )
     })
 
     /* SVG drawing */

diff --git a/src/locales/po-files/openverse.pot b/src/locales/po-files/openverse.pot
@@ -4,7 +4,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: Openverse \n"
 "Report-Msgid-Bugs-To: https://github.com/wordpress/openverse/issues \n"
-"POT-Creation-Date: 2022-03-18T03:49:09+00:00\n"
+"POT-Creation-Date: 2022-03-21T10:40:55+00:00\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
@@ -272,7 +272,7 @@ msgid "Audio seek bar"
 msgstr ""
 
 #. Do not translate words between ### ###.
-#: src/components/VAudioTrack/VWaveform.vue:578
+#: src/components/VAudioTrack/VWaveform.vue:580
 msgctxt "waveform.current-time"
 msgid "###time### second"
 msgid_plural "###time### seconds"