Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the AccessibleSVG component just Svg #9656

Closed
wants to merge 1 commit into from

Conversation

youknowriad
Copy link
Contributor

Related #9565 (comment)

All of our components should be accessible SVG so there's no point in adding Accessible in the name.

@youknowriad youknowriad added this to the 3.8 milestone Sep 6, 2018
@youknowriad youknowriad self-assigned this Sep 6, 2018
@youknowriad youknowriad requested a review from mtias September 6, 2018 13:04
@@ -1,7 +1,7 @@
// Components
export * from './primitives';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This thing overrides Svg from primitives now :)

We need to find out what would be the best strategy for maintaining Svg to make it work for both web and mobile (RN).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, maybe let's keep it as AccessibleSVG for now.

@youknowriad
Copy link
Contributor Author

youknowriad commented Sep 6, 2018

Closing, let's rediscuss this.

@youknowriad youknowriad closed this Sep 6, 2018
@youknowriad youknowriad deleted the rename/accessible-svg branch September 6, 2018 13:46
@aduth
Copy link
Member

aduth commented Sep 6, 2018

Closing, let's rediscuss this.

Where will this be discussed?

@gziolo
Copy link
Member

gziolo commented Sep 6, 2018

#9294 should be the place for start

@gziolo
Copy link
Member

gziolo commented Sep 7, 2018

I proposed an alternative approach in #9685. To make it work with React Native platform, I want to overload createElement to use react-native-svg elements instead of HTML types:

  • svg -> Svg (from react-native-svg)
  • path -> Path
  • g -> G
  • and so on

This would be applied only to the RN version of react implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants