Components: Mimic URLInput request abort on fetch #8049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
[Feature] UI Components
youknowriad
approved these changes
Jul 19, 2018
| onlyScrollIfNeeded: true, | ||
| } ); | ||
|
|
||
| setTimeout( () => { |
There was a problem hiding this comment.
Unrelated, we should probably replace this with withSafeTimeout :)
There was a problem hiding this comment.
We should probably not have setTimeout of any form 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8034
This pull request seeks to resolve an error which occurs when assigning the URL of a Button block. Notably, it replaces
Promise#abort(which does not exist) with an equivalent implementation checking for the request reference in an array which is reset both on subsequent requests and unmounting (when previously we were callingabort).Testing instructions:
Repeat testing instructions from #8034, ensuring there are no errors.