Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: Error when URLInput updates its suggestions #8034

Closed
aduth opened this issue Jul 18, 2018 · 0 comments · Fixed by #8049
Closed

Components: Error when URLInput updates its suggestions #8034

aduth opened this issue Jul 18, 2018 · 0 comments · Fixed by #8049
Assignees
@aduth
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Bug An existing feature does not function as intended
Milestone
3.3

Comments

@aduth
Copy link
Member

aduth commented Jul 18, 2018

Related: #7566, #7979 (comment)

Describe the bug

When changing the URL of a button block and unselected the block, the block throws an unhandled error.

To Reproduce

Steps to reproduce the behavior:

  1. Navigate to Posts > Add New
  2. Insert a Button block
  3. Insert a URL
  4. Unselect the block
  5. Observe block throws into error state

Expected behavior

No error occurs.

Screenshots

button-error

Additional context

I have a feeling this is related to the recent api-fetch refactor (#7566), changing from a jqXHR type (with abort function) to a Promise (from fetch) which has no cancellation.

Further, I think it's an issue that we're not ever unsetting this.suggestionsRequest when a request completes. There's no need to abort the request except when currently in-progress.
@aduth aduth added [Type] Bug An existing feature does not function as intended [Feature] UI Components Impacts or related to the UI component system labels Jul 18, 2018
@aduth aduth added this to the 3.3 milestone Jul 18, 2018
@aduth aduth assigned youknowriad and aduth and unassigned youknowriad Jul 18, 2018
@aduth aduth mentioned this issue Jul 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aduth aduth

Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
3.3
Development

Successfully merging a pull request may close this issue.

Components: Mimic URLInput request abort on fetch WordPress/gutenberg
2 participants
@youknowriad @aduth