Do not allow negative values in image dimensions #7656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajitbohra
added
[Type] Enhancement
ajitbohra
reviewed
Jul 1, 2018
components/text-control/index.js
Outdated
| @@ -5,7 +5,7 @@ import BaseControl from '../base-control'; | |||
| import withInstanceId from '../higher-order/with-instance-id'; | |||
| import './style.scss'; | |||
|
|
|||
| function TextControl( { label, value, help, className, instanceId, onChange, type = 'text', ...props } ) { | |||
| function TextControl( { label, value, help, className, instanceId, min, onChange, type = 'text', ...props } ) { | |||
There was a problem hiding this comment.
No need for the additional min attribute as ...props will pass the additional props added to the component
There was a problem hiding this comment.
Whoops, sorry, didn't realize that 😳 Just pushed a new commit which removes any changes from the component file.
Thank you so much for the review @ajitbohra ❤️
|
Are there any use cases for having an image use decimal dimensions <1 like 0.5×0.5? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses #7637 which reports the allowance of negative values in width and height input fields belonging to the block inspector settings of the image block.
How has this been tested?
This has been tested by making sure a minimum value of
1is enforced in the mentioned input fields so that no negative values are allowed.This was tested in WP 4.9.6, Gutenberg 3.1.1, Apache server with PHP 7.2.0 and MySQL 5.6.34. According to initial tests, the code doesn’t seem to affect any other areas.
Screenshots
Types of changes
This PR introduces a new attribute named
minin theTextControlelement, which is used in the image block's width and heightTextControlfields. A minimum value of1set in the fields so that negative values are not allowed. This uses HTMLinputfield'sminattribute, more details on that here.Checklist: