Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image block width and height input fields in inspector allow negative values #7637

Closed
ZebulanStanphill opened this issue Jun 29, 2018 · 2 comments
Labels
[Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.

Comments

@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Jun 29, 2018

The issue

The Width and Height input fields in the block inspector settings for the Image block allow negative values, but of course, that makes no sense, and the min HTML attribute can be used to set the minimum values on the inputs.

Related issues and PRs

@designsimply
Copy link
Member

Tested and confirmed that I am able to set negative values for image dimensions in the image block.

screen shot 2018-07-02 at mon jul 2 7 01 48 pm
Seen at http://alittletestblog.com/wp-admin/post.php?post=13859&action=edit running WordPress 4.9.6 and Gutenberg 3.1.1 using Firefox 61.0 on macOS 10.13.5.

@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] Media Anything that impacts the experience of managing media labels Jul 3, 2018
@ZebulanStanphill
Copy link
Member Author

Fixed by #7656.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants