Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image resizing should be operable with a keyboard #3977

Closed
afercia opened this issue Dec 13, 2017 · 4 comments
Closed

Image resizing should be operable with a keyboard #3977

afercia opened this issue Dec 13, 2017 · 4 comments
Labels
[Feature] Media Anything that impacts the experience of managing media [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@afercia
Copy link
Contributor

afercia commented Dec 13, 2017

Big thanks to Jackie D’Elia (@jdelia) who reported this during WCUS contributor's day.

Any action available in the editor should be operable also using only the keyboard.

When an image is selected, 4 "resize handlers" appear at the image 4 corners:

screen shot 2017-12-13 at 17 06 50

Clicking and dragging one of these handlers allows to resize the image (the ratio is preserved). Note this doesn't change the actual image size, it just shrinks the image within the browser and sets some CSS.

However, there's no way to resize the image using only the keyboard. At the very least, there should be an alternative way to do it, for example a couple input fields in the sidebar block settings, to allow users to enter the desired width/height. This would also allow all users to "fine-tune" the image size to the exact desired size. i'm not sure what unit measure should be used though (pixels? percentage?)

It would also be nice to add a "Reset" control, to bring back the image to its original size.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Dec 13, 2017
@mtias mtias added the [Feature] Media Anything that impacts the experience of managing media label Jan 3, 2018
@mellis32
Copy link

I agree with the strong need to add input fields, like resizing in the classic editor. Currently no way to enter the width and have the height scale automatically. A big loss of functionality.

@ZebulanStanphill
Copy link
Member

There are now input controls for resizing images in the block inspector for the Image block, including some presets and a Reset button. The only thing that seems to be missing is a way to set just the height or just the width of the image and have the other one automatically change to match. However, that may belong in a separate issue, so should this issue be closed now?

@afercia
Copy link
Contributor Author

afercia commented Jun 29, 2018

Yep I think this issue can be closed. @SuperGeniusZeb would you like to open a new issue for the "preserve ratio" thing? I've also noticed the width/height fields are a bit buggy:

  • click on width (initially set to 150), use the up arrow key to increase the value: it starts increasing but not from the current value, it first resets to 0 and then increases
  • both fields accept negative values 😬

@afercia afercia closed this as completed Jun 29, 2018
@ZebulanStanphill
Copy link
Member

@afercia I just created issues for all of those problems: #7636, #7637, and #7638.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

4 participants