iAPI Router: Revert "Handle styles assets on region-based navigation" #69222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAreRodz
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
luisherranz
approved these changes
Feb 17, 2025
luisherranz
added
the
Backport to Gutenberg RC
|
Size Change: +472 B (+0.03%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
@Mamaduka, it would be great if we could land this revert in WordPress 6.8. |
|
@cbravobernal, Gutenberg 20.4 will be part of WP 6.8, so no additional action is required. |
|
I just cherry-picked this PR to the release/20.3 branch to get it included in the next release: 4b7c573 |
fabiankaegy
removed
the
Backport to Gutenberg RC
|
Thanks, Fabian! 🙏 |
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reverts the work done for the style assets management implementation based on
document.adoptedStyleSheetsand constructedCSSStyleSheetinstances. Specifically, the following PRs are being reverted:This feature won't be included in Gutenberg until we find a solid way to update styles between pages using the iAPI's client-side navigation.
Why?
We've found the approach using
document.adoptedStyleSheetsis unreliable, as it doesn't work for linked style sheets whose content is restricted due to CORS policies. In such a case, our current implementation can't re-create the style sheet by reading its content, throwing the following error:Moreover, a
fetchcall trying to get the text content could also fail if the CSS style sheet is served without the appropriateAccess-Control-Allow-Originheader.For these cases, there's no way to construct a
CSSStyleSheetinstance to be included in theadoptedStyleSheetsproperty.