Fix the background, arrowUpLeft, keyboardReturn and square icons. #69076
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
afercia
added
[Type] Bug
|
Size Change: -22 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
afercia
changed the title
|
I added a fix to add back the
It should work fine now but this should be checked in all the places in the UI mentioned in #59669 , mainly the Link control and the like. I think #59669 wasn't a good solution and the icon size should be determined by the size of the containing Button. Cc @t-hamano The original problem reporteed in #58555 doesn't seem to occurr any longer? |
t-hamano
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
I added a fix to add back the
viewBoxof thekeyboardReturnicon that was removed in #59669
Based on this comment, I checked all the components that use the keyboardReturn icon and confirmed that there was no misalignment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #69075
By default, the the background and arrowUpLeft icons aren't visible because of an unexpected
fill="none"attribute set on their SVG component. Also, they misse the viewbox attribute. The square icon has an unnecessary the background, arrowUpLeft.Why?
Overall, the icons in the icons package should all use consistent props (attributes) passed to the SVG component to avoid unexpected wrong rendering with sizes, default colors etc.
Cc @WordPress/gutenberg-core @WordPress/gutenberg-design
How?
Uses the standard attributes passed to SVG compoent for all the other icons in the icons package.
Testing Instructions
npm run storybook:devTesting Instructions for Keyboard
Screenshots or screencast