You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The keyboardReturn icon has probems as well, it misses the viewBx attribute so that by defualt the sizes are messed up:
Will push an update to the associated PR.
afercia
changed the title
Fix the background, arrowUpLeft and square icons
Fix the background, arrowUpLeft, keyboardReturn and square icons
Feb 6, 2025
Re: the keyboardReturn icon, I see the viewBox was removed in #59669 intentionally. I'm not sure that was the correct fix. Rather, the buttons that contain the icon and the size passed to the Button should make the icon render correctly. Adding back the removed viewBox sems to work fine now.
Description
Icons in the icons package should use consistent props passed to the SVG component.
Turns out that:
viewBox="0 0 24 24"
attribute as such their default size is smaller than expectedwidth="24" height="24"
set, they are unnecessary because the size is added laterfill="none"
attribute so by default they are not visiblefill="none"
attribute which doesn't impact the visibility but it is unnecessaryintroduced in
#65183
#65304
#65497
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Please confirm which theme type you used for testing.
The text was updated successfully, but these errors were encountered: