-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top Toolbar: Show document bar when no block is selected even if block tools are expanded #65839
Conversation
…k tools are expanded
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +45 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Flaky tests detected in 7406106. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11148276191
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, this is testing nicely for me! 🚀
2024-10-03.16.15.26.mp4
…k tools are expanded (#65839) * Top Toolbar: Show document bar when no block is selected even if block tools are expanded * Change variable name to hasBlockSelection ---- Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: eatse21 <eatse@git.wordpress.org>
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 37e4dca |
I believe there was a problem in how this change was cherry-picked to the 6.7 branch — |
Thanks for flagging @ciampo, I'll push a commit to the release branch to fix it. |
Fixed in 6e8539b |
…k tools are expanded (WordPress#65839) * Top Toolbar: Show document bar when no block is selected even if block tools are expanded * Change variable name to hasBlockSelection ---- Co-authored-by: talldan <talldanwp@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: eatse21 <eatse@git.wordpress.org>
What?
Fixes #65824
Fixes an issue where the Document Bar isn't present when clicking 'Edit Original' on a synced pattern while Top Toolbar mode is activated.
Why?
The Document Bar usually hides when block tools are expanded if there's not enough space in the top bar.
When navigating to a pattern, the Block Tools are still considered expanded from the post being edited, even though they're not shown at all due to no block being selected.
How?
The fix is to show the document bar when there's no block selected, as in this case there won't be any block tools shown.
Testing Instructions
Screenshots or screencast
Before
After