Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Block: Update the minimum required PHP version to 7.2 #65166

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Sep 9, 2024

What?

PR updates required PHP versions set in create-block templates.

See: https://make.wordpress.org/core/2024/04/08/dropping-support-for-php-7-1/
See: #64920 (comment)

Testing Instructions

Check that the new PHP versions provided match WP standards.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Tool] Create Block /packages/create-block labels Sep 9, 2024
@Mamaduka Mamaduka self-assigned this Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: sirreal <jonsurrell@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka requested a review from sirreal September 9, 2024 17:49
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe some of the templates omit this. When the required PHP version is the same as the minimum required PHP version for the required WordPress Core version (WP 6.6 requires at least PHP 7.2) maybe we could just remove these annotations?

This looks good and can be shipped either way, thank you!

@Mamaduka
Copy link
Member Author

Mamaduka commented Sep 9, 2024

IIRC, these headers are also helpful if someone decides to publish a plugin on WP.org.

Doesn't display required PHP versions: https://wordpress.org/plugins/rtl-tester/
Displays required PHP versions: https://wordpress.org/plugins/bookmark-card/

@Mamaduka Mamaduka merged commit b758cca into trunk Sep 10, 2024
69 checks passed
@Mamaduka Mamaduka deleted the update/create-block-required-php branch September 10, 2024 10:36
@github-actions github-actions bot added this to the Gutenberg 19.3 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Tool] Create Block /packages/create-block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants