-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Block: Set minimum supported WordPress version to 6.6 #64920
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +7 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
@@ -16,7 +16,7 @@ module.exports = async ( { slug } ) => { | |||
info( | |||
'Installing `@wordpress/scripts` package. It might take a couple of minutes...' | |||
); | |||
await command( 'npm install @wordpress/scripts@27 --save-dev', { | |||
await command( 'npm install @wordpress/scripts --save-dev', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks, @gziolo!
Flaky tests detected in 987aef3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10629606085
|
…ss#64920) * Create Block: Set minimum supported WordPress version to 6.6 * Update changelog entries Co-authored-by: gziolo <gziolo@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
I see some of these say https://make.wordpress.org/core/handbook/references/php-compatibility-and-wordpress-versions/ |
Sure thing @sirreal. I didn’t notice that the min PHP version bumped to 7.2 as of WP 6.6. |
I'll create the follow-up PR. |
What?
Follow-up to #62234 where the
@wordpress/scripts
version got pinned to a version supported by WordPress 6.5. Now that WordPress 6.6 is out for a couple of weeks we can finally revert this change.Why?
WordPress 6.6 has all the necessary code to work with the latest version of
@wordpress/scripts
.How?
Remove the temorary version enforcment during
@wordpress/scripts
installation and set the minimum version for WordPress as 6.6 for all templates.Testing Instructions
Testing Instructions for Keyboard
Run the following locally:
Upload the zip file to the WordPress 6.6 instance, activate the plugin Example Block and ensure it works as expected.
Screenshots or screencast