Add: Reorder control at the field level on the new view config UI. #64381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Wouldn't these arrows make more sense sorting the order that the fields display (left to right in the table view, for example)? Seems a bit confusing that instead they seem to be duplicating the same functionality as the 'Sort by' and 'Order' fields above. |
Good point @paulwilde, I interpreted the arrows as sorting but maybe the plan was for reordering. @jameskoster could you clarify if the goal of the arrows was to sort or to reorder? |
|
@jorgefilipecosta yes these buttons are for re-ordering the display of fields as @paulwilde suggests. Sorry for the confusion! Perhaps we should try using |
jorgefilipecosta
force-pushed
the
add/sort-controls-at-field-level-on-view-config-ui
branch
from
13c8ec3 to
b958fdc
Compare
Hi @jameskoster, I updated this PR to make the buttons be reorder instead of sort (only available on table layout). And I also updated the icons. |
jorgefilipecosta
changed the title
|
Thanks for the update, we're getting close :)
|
jorgefilipecosta
force-pushed
the
add/sort-controls-at-field-level-on-view-config-ui
branch
from
b958fdc to
1a1152f
Compare
|
Hi @jameskoster the following items were addressed:
This issue was left out: However, only having the actions visible on hover minimizes the issue. It is not possible right now to allow setting the order of all fields regardless of visibility because the data structure that stores the field order is also the data structure that says if a field is visible, if a field is there it is visible and appears in that position. |
|
Size Change: +775 B (+0.04%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
I pushed a small update to the tooltips.
That sounds good, and fine to handle separately. In the mean time, instead of disabling the re-ordering buttons when a field is hidden, how about visually hiding them? |
jameskoster
reviewed
Aug 19, 2024
Comment on lines
289
to
292
| disabled={ | ||
| ! isVisible || index < 1 | ||
| } | ||
| accessibleWhenDisabled={ false } |
There was a problem hiding this comment.
Is there any reason not to use accessibleWhenDisabled={ true } here? Ideally the buttons are still accessible even when disabled.
jorgefilipecosta
force-pushed
the
add/sort-controls-at-field-level-on-view-config-ui
branch
from
6471713 to
fb30ef8
Compare
|
@jorgefilipecosta coming back to this point:
Would it be possible to have separate groups for hidden / visible fields? A quick mockup: 
Then we can hide the up/down buttons on the hidden fields. I think that would simplify the UX quite a bit, and hopefully negate the need to modify the data structure. What do you think? |
jorgefilipecosta
force-pushed
the
add/sort-controls-at-field-level-on-view-config-ui
branch
2 times, most recently
from
acc8111 to
f426514
Compare
|
Flaky tests detected in f426514. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10612850541
|
|
Hi @jameskoster your feedback was applied and I separated the visible and hidden fields into two groups. |
jameskoster
approved these changes
Aug 29, 2024
jorgefilipecosta
deleted the
add/sort-controls-at-field-level-on-view-config-ui
branch
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
…ordPress#64381) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: paulwilde <paulwilde@git.wordpress.org>
|
@jameskoster @jorgefilipecosta what are your thoughts on fields that are no visible and "not hidable" [1]? They will never be displayed in the layout, so, as a DataViews' consumer, I wouldn't want them to be listed in the properties panel. They are still useful for providing a filter, for example. You can see this at work in the default story for dataviews (see [1] A better naming would be: its visible/hide status cannot be changed by the user |
|
I agree, if users cannot toggle visibility then there's no point showing the field in the view options at this stage. |
Prepared #64999 that fixes this and a few other things. |
bph
added
[Package] DataViews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds buttons to sort directly at the field level on the new config UI.
Screenshot
cc: @WordPress/gutenberg-design
Testing Instructions
I verified the new sort buttons at the field level work as expected.