add sort labels

WordPress · Aug 8, 2024 · 13c8ec3 · 13c8ec3
1 parent c5af0ae
commit 13c8ec3
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/packages/dataviews/src/components/dataviews-view-config/index.tsx b/packages/dataviews/src/components/dataviews-view-config/index.tsx
@@ -22,7 +22,7 @@ import {
 	__experimentalText as Text,
 	privateApis as componentsPrivateApis,
 } from '@wordpress/components';
-import { __, _x } from '@wordpress/i18n';
+import { __, _x, sprintf } from '@wordpress/i18n';
 import { memo, useContext, useState, useMemo } from '@wordpress/element';
 import { arrowDown, arrowUp, cog, seen, unseen } from '@wordpress/icons';
 import warning from '@wordpress/warning';
@@ -275,11 +275,11 @@ function FieldControl() {
 										} )
 									}
 									icon={ arrowUp }
-									label={
-										isVisible
-											? __( 'Remove from sort' )
-											: __( 'Add to sort' )
-									}
+									label={ sprintf(
+										/* translators: %s: field label */
+										__( 'Sort ascending by: %s' ),
+										field.label
+									) }
 								/>
 								<Button
 									isPressed={
@@ -299,11 +299,11 @@ function FieldControl() {
 										} )
 									}
 									icon={ arrowDown }
-									label={
-										isVisible
-											? __( 'Remove from sort' )
-											: __( 'Add to sort' )
-									}
+									label={ sprintf(
+										/* translators: %s: field label */
+										__( 'Sort descending by: %s' ),
+										field.label
+									) }
 								/>
 								<Button
 									disabled={ ! isHidable }