Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patterns: enable cross-browser support for pattern uploading #64123

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Patterns: enable cross-browser support for pattern uploading #64123

merged 2 commits into from
Jul 31, 2024

Commits on Jul 31, 2024

  1. Uploading pattern JSON files was triggering an error in Firefox "cate… 

    …goryMap.values().find is not a function".

categoryMap.values() method returns an iterator.
Iterator.find() doesn't have wide browser support. It doesn't work in Firefox, Safari and others.

Converting categoryMap.values() iterator to an array allow the use of find()
    @ramonjd
    ramonjd committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    98db884 View commit details
    Browse the repository at this point in the history

  2. Comment tweak.

    @ramonjd
    ramonjd committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    f08bc21 View commit details
    Browse the repository at this point in the history