Patterns: enable cross-browser support for pattern uploading #64123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…goryMap.values().find is not a function". categoryMap.values() method returns an iterator. Iterator.find() doesn't have wide browser support. It doesn't work in Firefox, Safari and others. Converting categoryMap.values() iterator to an array allow the use of find()
ramonjd
added
[Type] Bug
ramonjd
requested review from
jsnajdr,
talldan,
andrewserong,
ntsekouras and
aaronrobertshaw
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +3 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Jul 31, 2024
|
The |
|
I see it now: Calypso polyfills only stable features ( |
|
@jsnajdr Thank you! So, do you think reverting and adding the polyfill would be better? |
|
Depends on whether we want to use experimental JS features in Calypso. Gutenberg has a conservative policy that only features that are already in a published standard can be used. But Calypso could be more liberal 🙂 I think all you need is to add the following import to import 'core-js/proposals/iterator-helpers-stage-3';and then you can start using all the iterator helper methods like At the same time let's upgrade |
7 tasks
|
Core/Gutenberg won't use the polyfills, you're right, but I've tentatively added a PR to introduce them to Calypso. I'll follow your judgement there, and whether to merge it. It's been a while since I've Calypsoed, so to speak. |
|
Oh, now I see I've been commenting on a Gutenberg PR thinking I'm in the Calypso repo 🙂 Sorry if my comments were confusing! |
It's okay! ❤️ I had a bit of time to throw up a calypso PR, but I think I'll abandon it given the feedback. I'm probably not the right person to do it anyway 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It's not possible to upload patterns in Firefox and Safari and other browsers that don't yet support Iterator.prototype.find().
Props to @juliacanzani for spotting this!
Why?
Uploading pattern JSON files was triggering an error in Firefox and Safari:
"categoryMap.values().find is not a function".categoryMap.values() returns an Iterator.
Iterator.prototype.find() doesn't have wide browser support.
How?
Let's covert the
categoryMap.values()iterator to an array to allow the use ofArray.prototype.find()Testing Instructions
Kapture.2024-07-31.at.11.02.02.mp4