Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Downgrade node 22(.5) unit tests to 22.4 (#63728)" #63758

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented Jul 19, 2024

This reverts commit 32b4b2e.

A bug fix release. 22.5.1 has been published that hopefully fixes the problems that were causing failed builds earlier this week.

@desrosj desrosj self-assigned this Jul 19, 2024
Copy link

github-actions bot commented Jul 19, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
Copy link
Contributor Author

desrosj commented Jul 19, 2024

It seems that the version of node has been published for actions/node-versions, but there's likely still some deploying that is in progress or needs to happen.

@desrosj desrosj requested a review from talldan July 22, 2024 16:31
@desrosj
Copy link
Contributor Author

desrosj commented Jul 22, 2024

Looks like things are back green again. I reverted the merge commit wholesale, but I'm not opposed to keeping the changes around introducing a name for each value. Though those change anyway when we change the version in the matrix, so it doesn't solve the same problem.

@talldan talldan added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Aug 27, 2024
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @desrosj for remembering to do this 😄

@talldan talldan merged commit 2520296 into trunk Aug 27, 2024
64 checks passed
@talldan talldan deleted the revert/pin-nodejs-22.5 branch August 27, 2024 05:55
@github-actions github-actions bot added this to the Gutenberg 19.2 milestone Aug 27, 2024
bph pushed a commit to bph/gutenberg that referenced this pull request Aug 31, 2024
…ordPress#63758)

This reverts commit 32b4b2e.

Co-authored-by: Jonathan Desrosiers <desrosj@users.noreply.github.com>
Co-authored-by: desrosj <desrosj@git.wordpress.org>
Co-authored-by: talldan <talldanwp@git.wordpress.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants