Downgrade node 22(.5) unit tests to 22.4 #63728
Conversation
talldan
added
the
[Type] Automated Testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
talldan
force-pushed
the
try/running-node-22-tests-on-22.4-temporarily
branch
from
b6fb961 to
d1b0f9d
Compare
talldan
changed the title
| @@ -14,13 +14,17 @@ concurrency: | |||
|
|
|||
| jobs: | |||
| checks: | |||
| name: Checks w/Node.js ${{ matrix.node }} on ${{ matrix.os }} | |||
| name: Checks w/Node.js ${{ matrix.node.name }} on ${{ matrix.os }} | |||
There was a problem hiding this comment.
This way the job names don't change, it'll still be something like "Create Block / Checks w/Node.js 22 on macos-latest (pull_request)" and it means I won't have to change required checks in github's setting back and forth.
In future we might consider keeping this and using names like "LTS" and "Next" instead of specific version numbers.
| node: | ||
| - name: 20 | ||
| version: 20 | ||
| - name: 22 | ||
| version: 22.4 |
There was a problem hiding this comment.
Array/Object notation in yaml, as documented here:
https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs
|
This seems to be working so merging it into trunk |
…ordPress#63758) This reverts commit 32b4b2e. Co-authored-by: Jonathan Desrosiers <desrosj@users.noreply.github.com> Co-authored-by: desrosj <desrosj@git.wordpress.org> Co-authored-by: talldan <talldanwp@git.wordpress.org>
Currently all node 22 unit tests are failing in trunk. It seems to be an issue for npm running on node 22.5.
Comments on npm/cli#7657 imply this is an npm bug, and running on node 22.4 can be a temporary measure to keep CI working.