Pattern Shuffling: Only use the category that the user selected to shuffle patterns #60088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Enhancement
scruffian
commented
Mar 21, 2024
|
Size Change: -1.28 kB (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ajlende
force-pushed
the
update/pattern-category-shuffling
branch
from
79690d9 to
25a33bd
Compare
ajlende
reviewed
Mar 21, 2024
| @@ -772,7 +799,8 @@ export const blocks = pipe( | |||
| withBlockReset, | |||
| withPersistentBlockChange, | |||
| withIgnoredBlockChange, | |||
| withResetControlledBlocks | |||
| withResetControlledBlocks, | |||
| withPatternCategory | |||
There was a problem hiding this comment.
It seems like this is running before the attributes function below, so the below function is overwriting the attribute changes we're making.
There was a problem hiding this comment.
How can it be fixed? Since this causes this PR to no do what it says on the tin :)
There was a problem hiding this comment.
I think this means we can't use a separate reducer, so I built it into the attributes reducer.
|
It's not 100% ideal to cycle among "featured" patterns, if inserted with the "featured" category. Should we omit that from being selected as a shuffle-able category as well? |
richtabor
force-pushed
the
update/pattern-category-shuffling
branch
from
25a33bd to
f1b4426
Compare
richtabor
reviewed
Apr 3, 2024
|
Rebased as well. |
scruffian
force-pushed
the
update/pattern-category-shuffling
branch
from
f1b4426 to
9849ddb
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
reviewed
Apr 26, 2024
| */ | ||
| function addSelectedPatternCategoryToOuterBlock( { meta, blocks } ) { | ||
| if ( meta?.category && blocks.length === 1 ) { | ||
| blocks[ 0 ].attributes.metadata.categories = [ meta.category.name ]; |
There was a problem hiding this comment.
I'm wondering if category is too generic for the metadata. It's more about the "pattern category at point of insertion".
getdave
reviewed
Apr 26, 2024
Comment on lines
+868
to
+869
| const newBlocks = | ||
| addSelectedPatternCategoryToOuterBlock( action ); |
There was a problem hiding this comment.
This feels like it should be called conditionally.
Also it's feeling a little bit like a side effect in a reducer.
Are "Patterns" a concept in the block editor outside of the WordPress context? If not then should we be adding this to the block editor store?
There was a problem hiding this comment.
The original approach used a different reducer before this one, to try to keep the concerns separate. However this one addresses actions.block directly, so any changes we make to the blocks before this point are overridden by this one.
|
Closing in favour of #61557 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This uses the category the user selected as the basis for pattern shuffling - so if a pattern has more than one category, we only use the one that the user selected the category from instead of all the categories that the pattern is in.
Why?
It can be confusing when a category is in multiple categories, so this helps to keep the shuffling contained to the one category the user selected.
How?
We pass the category name into the reducer and add it to the block metadata.
Testing Instructions
teamcategory, not theaboutcategory.Screenshots or screencast