Pattern Shuffling: Make the results deterministic #60074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Enhancement
|
Size Change: +252 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
I don't think it's particularly helpful having the pattern's name here, likely distracting even. Was that intentional?
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
No! I'll fix it :) |
|
Good stuff. Regarding metadata.name, is it possible to name it only if a name does not exist? For example, TT4 has a testimonials pattern with a name assigned to the group block. I think it may be unexpected that the name would be omitted. What do you think? |
Good idea, done: |
scruffian
force-pushed
the
add/deterministic-shuffle
branch
from
176bbd8 to
27fe1bf
Compare
|
It would be good to have a technical review on this cc @jorgefilipecosta @draganescu |
draganescu
reviewed
Mar 25, 2024
talldan
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
It works well for me, this is a nice simple solution.
I think this is good but we should consider if we should then cycle instead of shuffle as UX
@draganescu I guess it depends on whether the user can tell the difference.
Comment on lines
2289
to
+2290
| categories: pattern.categories, | ||
| patternName: pattern.name, |
There was a problem hiding this comment.
Nit, but I wonder if these could be grouped together:
shuffle: {
categories: pattern.categories,
name: pattern.name,
}There was a problem hiding this comment.
That does mean we can be consistent with naming which is nicer, but they may be used for things other than shuffle...
There was a problem hiding this comment.
True. The patternName could be useful for a few things.
The categories are only for the originally inserted pattern though, as a user shuffles, the newly shown pattern might have different categories to those stored in the attribute (though will always have one category in common), so that feels more like a search parameter for the shuffle feature.
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
* Pattern Shuffling: Make the results deterministic * Use the title field as a name and save the pattern name in patternName * Only use the pattern name if the group doesn't have a name * updated snapshots for inserting-blocks.spec.js * fixed test --------- Co-authored-by: MaggieCabrera <maggie.cabrera@automattic.com>
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
* Pattern Shuffling: Make the results deterministic * Use the title field as a name and save the pattern name in patternName * Only use the pattern name if the group doesn't have a name * updated snapshots for inserting-blocks.spec.js * fixed test --------- Co-authored-by: MaggieCabrera <maggie.cabrera@automattic.com>
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This changes the way pattern shuffling works so that the results are deterministic not random. The patterns just cycle through the list of patterns in the category.
Why?
Random shuffle isn't very useful - you might see the same pattern multiple times while not seeing the other options. It's more useful for users to be presented with the options in a more evenly spread way.
How?
We find the index of the current pattern in the category and return the next one in that array, or the first one if its the last one.
Testing Instructions
Screenshots or screencast
Screen.Recording.2024-03-21.at.13.24.15.mov