Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default overlay color to black #59894

Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

akasunil
Copy link
Member

What?

Fixes #49785

Why?

Default overlay color isn't set in cover block, but we were loading black color though css, but the actual color picker shows nothing set.

How?

Set default value to black, It will show black color selected in overlay color picker.

Testing Instructions

  1. Add cover block
  2. Check overlay color in block setting

@akasunil akasunil requested a review from ajitbohra as a code owner March 15, 2024 09:16
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sunil25393 <sunil25393@git.wordpress.org>
Co-authored-by: Thelmachido <thelmachido@git.wordpress.org>
Co-authored-by: Olein-jp <olein@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@akasunil akasunil marked this pull request as draft April 29, 2024 06:33
@akasunil akasunil added [Type] Enhancement A suggestion for improvement. [Block] Cover Affects the Cover Block - used to display content laid over a background image labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not set of initial colour preset setting for the overlay colour
1 participant