Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not set of initial colour preset setting for the overlay colour #49785

Open
Olein-jp opened this issue Apr 13, 2023 · 1 comment · May be fixed by #59894
Open

Not set of initial colour preset setting for the overlay colour #49785

Olein-jp opened this issue Apr 13, 2023 · 1 comment · May be fixed by #59894
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Block settings menu The block settings screen [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@Olein-jp
Copy link
Contributor

Description

When the cover block is placed, dim-100 is set as the initial overlay colour, but the actual colour swatch shows nothing set.

However, when the overlay level is changed, the overlay opacity is actually applied with dim-100 applied, which may confuse some users.

It would be preferable to have the colour palette set to dim-100 rather than blank in the initial state when the cover block is placed.

Step-by-step reproduction instructions

  1. Place the cover block
  2. Set a background image and some text
  3. Make sure that nothing is set in the colour palette of the overlay opacity from the style panel
  4. Change the value of the overlay opacity and check that dim-100 is actually applied and changed on the editor side
  5. Access the front side and confirm that dim-100 is applied to the overlay in the dev tool as set in the editor side.
  6. Go back to the editor side again and check that no colour is set in the colour preset.

Screenshots, screen recording, code snippet

2023-04-13.11.08.19.mov

Environment info

  • WordPress 6.2
  • TT3 Activated
  • No plugins activated

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Thelmachido
Copy link

I can confirm this, however, by default the cover blocks' background dim color is set to black. So when you change the opacity - this is manipulating the default color.

.wp-block-cover .has-background-dim:not([class*=-background-color]) {
    background-color: #000;
}

It might be better to show the reflect this color on the cover block settings. At the moment, the cover block makes it seem like it comes without an overlay color as shown below.

Screenshot 2023-04-13 at 15 37 24

@Thelmachido Thelmachido added [Type] Enhancement A suggestion for improvement. [Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Block settings menu The block settings screen labels Apr 13, 2023
@akasunil akasunil linked a pull request Mar 15, 2024 that will close this issue
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Feature] Block settings menu The block settings screen [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants