Update: Dataviews do not use strings on isCustom props passed down. #59609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +9 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
update/dataviews-dont-use-string-for-on-isCustom-props-passed-down
branch
from
e374119 to
a3dec76
Compare
jorgefilipecosta
deleted the
update/dataviews-dont-use-string-for-on-isCustom-props-passed-down
branch
andrewserong
added
the
[Feature] DataViews
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
…ordPress#59609) Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies feedback from @mcsf at #55773 (review). The feedback entailed ensuring that we don't pass down an 'isCustom' prop as a string. We now convert the variable to a boolean before passing it down to ensure that the type is consistent with its name.
Testing Instructions:
I went to manage all pages and navigated between different views. I also created a new custom view and verified that everything worked as expected.