DataViews: Add ability to create custom views #55773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
force-pushed
the
add/ability-to-create-custom-dataviews
branch
from
c88d90d to
ff85973
Compare
|
Size Change: +814 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ff85973. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6722812336
|
|
Loading this PR gives me the following state, I'm guessing this is because of the old behavior I tested in the other branches. 
But I think it highlight something important. There's nothing in the URL that tells us where to look for a view (whether it's a global view or a custom one), I think that distinction should be in the URL rather than trying our best to match with both categories. If later down the road, we have a unique endpoint to match both types, it would make sense to remove that "type" or something from the url but for now, we're looking for these in two different plages so we need to know before hand. |
|
When creating a view, I expected the url to change to go to that newly created view. |
|
I also wonder if we should separate both in the sidebar. (have a title for "custom views" similar to the one we have for "template parts") |
I think we should separate both in the UI and is on of the follow-ups I suggested. I think we can leave for a future PR as this one is already starting to get too big. |
jorgefilipecosta
changed the title
jorgefilipecosta
force-pushed
the
add/ability-to-create-custom-dataviews
branch
from
ff85973 to
b678ccf
Compare
|
Hi @youknowriad, |
jorgefilipecosta
force-pushed
the
add/ability-to-create-custom-dataviews
branch
from
b678ccf to
1e0752c
Compare
youknowriad
reviewed
Nov 3, 2023
| @@ -39,19 +44,74 @@ const defaultConfigPerViewType = { | |||
| }, | |||
| }; | |||
|
|
|||
| export default function PagePages() { | |||
| const PATH_TO_TYPE = { | |||
There was a problem hiding this comment.
This const is a bit weird, specially since we're already rendering "page", so we can just use "page" directly.
youknowriad
reviewed
Nov 3, 2023
| DEFAULT_VIEWS[ type ].find( ( { slug } ) => slug === activeView )?.view; | ||
| const [ view, setView ] = useState( selectedDefaultView ); | ||
|
|
||
| const customViews = useCustomDataViews( type ); |
There was a problem hiding this comment.
Not sure I understand why we need this hook, specially since we're calling getEditedEntityRecord right after.
There was a problem hiding this comment.
Oh you're using the slug in the url, why not just the id directly? it would simplify a lot of things IMO
There was a problem hiding this comment.
Updated to use the id directly.
youknowriad
reviewed
Nov 3, 2023
| ); | ||
| }, | ||
| ]; | ||
| }, [ editEntityRecord, editedViewRecord?.content, editedViewRecord?.id ] ); |
There was a problem hiding this comment.
I think it's not great that the onChange depend on the value itself. Ideally the customView and setCustomView should be memoized separately.
There was a problem hiding this comment.
Updated to memoize separately.
jorgefilipecosta
force-pushed
the
add/ability-to-create-custom-dataviews
branch
3 times, most recently
from
f829850 to
10030d1
Compare
|
Hi @youknowriad your second round of feedback was applied 👍 |
Squashed commits: [b107c819e2] Feedback application [8ba71aaab4] Post rebase conflicts [13eb412e35] Add: Ability to crate custom DataViews.
jorgefilipecosta
force-pushed
the
add/ability-to-create-custom-dataviews
branch
from
10030d1 to
b240331
Compare
|
As a note old custom views may now crash the application because the view shape was changed. Please delete old views by changing show_ui flags to true in lib/experimental/data-views.php and then using the post manager UI to delete the view posts. Or ignore the old custom views and create new ones. We will need a view versioning system and a way to migrate old view shapes (like we have for blocks and global styles), but right now we are iterating fast, and thinking about view migrations is just something to slow us down. |
youknowriad
approved these changes
Nov 6, 2023
oandregal
added
[Type] Feature
|
This PR was missing the type and feature labels for the changelog – added them now. |
oandregal
changed the title
oandregal
added
[Type] Experimental
mcsf
reviewed
Feb 9, 2024
|
|
||
| const linkInfo = useLink( { | ||
| path, | ||
| activeView: isCustom === 'true' ? customViewId : slug, |
There was a problem hiding this comment.
It's super confusing to have isCustom as a string. How did this come to be? Is it because of how params are expected by useLink? Or is it due to how values are parsed from template records? Either way, shouldn't we be casting to boolean and vice-versa? If not, this prop should probably have a less ambiguous name. /cc @jorgefilipecosta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, users can now create their own personalized views, which can be saved and stored in the database. The main focus of this PR is on setting up the necessary mechanisms to add post types and taxonomies, as well as ensuring that the views are correctly referenced and saved to the appropriate entities. However, further UI work will be required in order to distinguish between custom and default views, as well as to enable users to rename or delete their custom views.
Screenshots