Block editor: remove 4 useSelect in favour of context #56915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -82 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e0da783. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7165552576
|
ellatrix
force-pushed
the
perf/combine-display-controls-select
branch
from
a412e94 to
95710ab
Compare
youknowriad
reviewed
Dec 10, 2023
|
|
||
| export default function useBlockControlsFill( group, shareWithChildBlocks ) { | ||
| const { isDisplayed, isParentDisplayed } = useDisplayBlockControls(); | ||
| if ( isDisplayed ) { | ||
| const { mayDisplayControls, mayDisplayParentControls } = |
There was a problem hiding this comment.
So these are two new APIs?
There was a problem hiding this comment.
This is internal context right?
There was a problem hiding this comment.
Oh, I guess it's not... We could lock it with symbols I guess?
ellatrix
force-pushed
the
perf/combine-display-controls-select
branch
from
c6ba25c to
69c9d34
Compare
youknowriad
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
#56847 has proven that the number of useSelect calls per block are definitely affecting performance. This PR removes another 4* of those separate store subscriptions, reuses the existing main block component subscription, and passes it down to slots and hooks through context (we already do that for clientId, name, etc.)
(*) Inspector slot, toolbar slot, block info slot, and one for hooks.
Why?
See above.
How?
Using context.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast