useBlockProps: combine store subscriptions #56847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
changed the title
|
Size Change: -74 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 505a007. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7126509659
|
youknowriad
approved these changes
Dec 7, 2023
ellatrix
force-pushed
the
try/use-block-props-reduce-selectors
branch
from
2e3891e to
07ed00a
Compare
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR reduces the amount of store subscriptions per block by 7 (so per editor, times the amount of blocks).
It also combines two rich text useSelect calls, but that probably has no impact because it doesn't subscribe to the block editor store. It does remove a
useMemocall though, so that's nice.Why?
Even though adding subscription handlers to the priority queue map should be super quick, there being a huge number for a large post means that lots of time is spent adding each of those. For a large post it seems like it's taking up half the work!
The only thing we can do, I think, is to reduce the amount of subscriptions per block. This PR reduces the number of subscriptions that need to be added on type by 20% (I logged the add method of
addbefore and after).How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast