[WIP]Patterns: refactor use of pattern type to indicate category type #54766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
[Type] Code Quality
|
Size Change: +75 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
There have been a lot of changes around patterns since opening this, so largely redundant at this stage I think. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a new pattern category constant and replaces uses of the pattern type to indicate category type in the site editor.
Why?
Currently the PATTERN_TYPE constant is used to indicate category type, which is a little confusion now that both user and theme patterns share the category section.
How?
Adds a new PATTERN_CATEGORY_TYPE constant to the patterns package and uses this via the packages private API in the edit site package.
Testing Instructions
Will add test instructions if we decide to go with this approach - still under discussion.