Patterns: Fix category type for back link #54753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
aaronrobertshaw
added
the
Backport to Gutenberg RC
|
Size Change: +3 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
kevin940726
approved these changes
Sep 24, 2023
glendaviesnz
approved these changes
Sep 24, 2023
There was a problem hiding this comment.
Tested well for me.
I think the use of pattern type is a little confusing now that user and theme essentially share the same category section. I wonder if we should introduce a PATTERN_CATEGORY_TYPE constant to reduce any potential confusion around this. I have a draft PR for this, but I think we should land this simple fix for 16.7, and look at that refactor post the 6.4 beta if we want to do that.
|
I just cherry-picked this PR to the release/16.7 branch to get it included in the next release: 5ebd804 |
mikachan
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
What?
Fixes the category type applied to a pattern's URL so that when navigating back to the pattern management page the sync filters are shown as they were before selecting the pattern.
Why?
UI elements coming and going isn't great.
How?
Set the correct category type in the query string params
Testing Instructions
Replicate Issue
Test fix
patternScreenshots or screencast
Screen.Recording.2023-09-23.at.4.21.19.pm.mp4
Screen.Recording.2023-09-23.at.4.22.31.pm.mp4