Replace edit icon for text based button in details panel #54365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richtabor
added
Needs Design Feedback
|
Size Change: +128 B (0%) Total Size: 1.52 MB
ℹ️ View Unchanged
|
|
+1 for using the word, it's so much clearer. Assuming this will resize gracefully in other languages. |
jasmussen
requested changes
Sep 12, 2023
There was a problem hiding this comment.
I hate to block this, but we initially tried this in some earlier mockups, not both due to translations, the amount of icons needing to be there in the title area (up to three total), this design did not work. If we need to provide a label for editing, the button needs to sit in a different place.
|
It's all good @jasmussen, just a quick pr to feel it out. I may pull out the metric mods and revitalize my old metrics pr.
Also, what's the third icon/action? |
|
I just remembered, it's from an older mockup, but you'd have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
An alternative to #54190, which aims to reduce the confusion between the pencil icon for renaming and editing the template/page. I used the
Also cleans up the title area metrics a bit.
How?
Testing Instructions
Screenshots or screencast