Try Site Editor panel metrics #51599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +45 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
richtabor
added
the
[Feature] Site Editor
|
Flaky tests detected in 72dd4ff. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5523739448
|
|
These changes seem reasonable to me. I particularly appreciate the equal left/right padding 😌 Just a couple of small observations... The panel title and site title are ever-so-slightly out of alignment, is it worth finessing that? 
When menu items don't have an icon, they seem to hang too far over on the left: 
|
|
@jameskoster I can give it another run tomorrow, but feel free to push to the branch if you’d like to have at it. |
jameskoster
approved these changes
Jun 20, 2023
|
@richtabor how do you feel about merging this one? |
|
Restarted the failing tests in case they were flaky. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
General tweaks to adjusting metrics for the Site Editor panels. Was investigating #51581 and decided to spin up a more holistic proposal that will also close #51581.
Generally aligns icons a bit better on the right, and ensures MenuItem spacing is equal on both sides.
Testing Instructions
Screenshots
Before
After